-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] [linux] Support creating fullscreen window by "ti.GUI(fullscreen=True)" #1921
Conversation
taichi/gui/win32.cpp
Outdated
style &= ~WS_CAPTION & ~WS_SIZEBOX; | ||
SetWindowLong(hwnd, GWL_STYLE, style); | ||
SetWindowPos(hwnd, NULL, 0, 0, GetSystemMetrics(SM_CXSCREEN), | ||
GetSystemMetrics(SM_CYSCREEN), SWP_NOZORDER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JYLeeLYJ Would you confirm if this part works? many thanks!
LGTM! I ran it on Ubuntu 18.04 and tried it on fractals, nbody_oscillator and taichi_logo and it works. Not all of the examples listen for an escape key, so it was a bit of an issue for me to minimize the window until I found the keyboard shortcut. For MacOS: Add
to the end of Lines 268 to 311 in 094baad
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
awasasas merge trig
Related issue = taichi-dev/taichi_three#20 (comment)
[Click here for the format server]
This PR use the method in https://stackoverflow.com/questions/9083273/x11-fullscreen-window-opengl to support fullscreen on X11. We'd add this to Win32 and Cocoa too iapr.