-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async] [opt] Field value killing analysis #1929
Conversation
Not sure if the SFG is correct after this PR... I'll take a deeper look tmr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 42.80% 43.72% +0.92%
==========================================
Files 45 45
Lines 6413 6207 -206
Branches 1101 1103 +2
==========================================
- Hits 2745 2714 -31
+ Misses 3498 3322 -176
- Partials 170 171 +1
Continue to review full report at Codecov.
|
Related issue = #742
Changes:
SNode
s' original values before theOffloadedStmt
are read inside theOffloadedStmt
, and whichGlobalPtrStmt
s' original value is still reachable at the end of theOffloadedStmt
. These two cases, together withSNode
s that are not element-wise written, should be the set of input value states in theTaskMeta
.[Click here for the format server]