Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move OffloadedStmt::TaskType to a separate file #1946

Merged
merged 12 commits into from
Oct 13, 2020

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan xumingkuan commented Oct 12, 2020

Related issue = #

Taichi build time on my laptop if ir.h is modified:

  • Without power plugged in: 6m7s (energy saving mode...) -> 3m57s
  • With power plugged in: 3m7s -> 2m55s

[Click here for the format server]


@xumingkuan
Copy link
Contributor Author

xumingkuan commented Oct 12, 2020

Although CI looks good, the build fails on my laptop...?

Update: rebuild succeeded.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   43.65%   43.65%           
=======================================
  Files          45       45           
  Lines        6226     6226           
  Branches     1107     1107           
=======================================
  Hits         2718     2718           
  Misses       3334     3334           
  Partials      174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855adc8...21b198c. Read the comment docs.

# Conflicts:
#	taichi/program/async_engine.cpp
#	taichi/transforms/ir_printer.cpp
#	taichi/transforms/make_thread_local.cpp
@xumingkuan xumingkuan marked this pull request as ready for review October 12, 2020 15:47
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@yuanming-hu yuanming-hu merged commit 2a71e2a into taichi-dev:master Oct 13, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 14, 2020
@xumingkuan xumingkuan deleted the tasktype branch March 13, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants