-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [lang] Fix error when subscripting a dict #1950
Conversation
python/taichi/lang/impl.py
Outdated
ti.ndrange, ti.GroupedNDRange)) or x is None: | ||
return x | ||
elif isinstance(x, ti.lang.expr.Expr) and x.ptr.is_global_var(): | ||
ti.ndrange, ti.GroupedNDRange, zip, filter, map)) or x is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OFT further extend static-for possibilities.
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
==========================================
+ Coverage 42.80% 43.64% +0.84%
==========================================
Files 45 45
Lines 6413 6225 -188
Branches 1101 1106 +5
==========================================
- Hits 2745 2717 -28
+ Misses 3498 3334 -164
- Partials 170 174 +4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! LGTM. Thank you!
Related issue = #
A collection of several random yet trivial fixes.
[Click here for the format server]