Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Set CMAKE_CXX_STANDARD to 17 #1964

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

xumingkuan
Copy link
Contributor

This is to let CLion recognize C++17 features... Without this line (set(CMAKE_CXX_STANDARD 17)), CLion keeps complaining about stuff like std::optional does not name a type.

See also https://stackoverflow.com/questions/53505844/clion-does-not-recognise-c17-features.

[Click here for the format server]


@xumingkuan xumingkuan requested a review from k-ye October 16, 2020 12:32
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1964 into master will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1964      +/-   ##
==========================================
+ Coverage   42.69%   43.64%   +0.94%     
==========================================
  Files          45       45              
  Lines        6436     6225     -211     
  Branches     1106     1106              
==========================================
- Hits         2748     2717      -31     
+ Misses       3513     3334     -179     
+ Partials      175      174       -1     
Impacted Files Coverage Δ
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/testing.py 75.00% <0.00%> (-0.72%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/meta.py 62.82% <0.00%> (-0.48%) ⬇️
python/taichi/lang/__init__.py 40.45% <0.00%> (-0.33%) ⬇️
python/taichi/misc/util.py 18.27% <0.00%> (-0.24%) ⬇️
python/taichi/misc/task.py 0.00% <0.00%> (ø)
python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
python/taichi/lang/kernel.py 71.39% <0.00%> (+0.13%) ⬆️
python/taichi/misc/gui.py 8.89% <0.00%> (+0.18%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706c519...ee9a1f8. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I guess it may make more sense to move this line to the very beginning of the root CMakeLists.txt, since this option applies to the entire project?

As a CLion user on Linux, I didn't run into the warning. It seems to be platform-specific.

@yuanming-hu yuanming-hu removed the request for review from k-ye October 16, 2020 15:45
@yuanming-hu yuanming-hu merged commit 340f4b0 into taichi-dev:master Oct 16, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 17, 2020
@xumingkuan xumingkuan deleted the cmake branch March 13, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants