Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [lang] Fix some missing operator overrides like __rlshift__ #1978

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate changed the title [Bug] [Lang] Fix some missing operator overrides like __rand__ [Bug] [lang] Fix some missing operator overrides like __rlshift__ Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1978 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
- Coverage   43.67%   43.43%   -0.24%     
==========================================
  Files          45       45              
  Lines        6230     6264      +34     
  Branches     1106     1108       +2     
==========================================
  Hits         2721     2721              
- Misses       3335     3369      +34     
  Partials      174      174              
Impacted Files Coverage Δ
python/taichi/lang/common_ops.py 59.92% <0.00%> (-9.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729a23c...3d55ee2. Read the comment docs.

Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix!

@TH3CHARLie TH3CHARLie merged commit 523c68a into taichi-dev:master Oct 21, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left shift operation between int and taichi field element is not supported in taichi scope
2 participants