Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Create helper methods for TLS codegen #1982

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Oct 21, 2020

Follow up on #1949 to clean up the code a bit..

Related issue = #1949

[Click here for the format server]


@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #1982 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1982   +/-   ##
=======================================
  Coverage   43.43%   43.43%           
=======================================
  Files          45       45           
  Lines        6264     6264           
  Branches     1108     1108           
=======================================
  Hits         2721     2721           
  Misses       3369     3369           
  Partials      174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523c68a...026d974. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@yuanming-hu yuanming-hu merged commit 6e68872 into taichi-dev:master Oct 21, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 21, 2020
@k-ye k-ye deleted the mtl-unify-tls branch October 25, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants