Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] Simplify bit_cast of bit_cast #2152

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

xumingkuan
Copy link
Contributor

Related issue = #656

Also adds DelayedIRModifier::mark_as_modified() because this pattern (modifying IR, not through DelayedIRModifier, but need to record if the IR is modified) repeats in some other passes.

[Click here for the format server]


Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM.

@yuanming-hu yuanming-hu merged commit b533d92 into taichi-dev:master Jan 12, 2021
@k-ye k-ye mentioned this pull request Feb 4, 2021
@xumingkuan xumingkuan deleted the cast branch March 13, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants