[refactor] Create a library taichi_isolated_core that is free from pybind11 #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this means that Taichi is going to expose CHI IR to serve other frontend languages than Python?
无法顺畅的大口呼吸，是活着的最好证明
…---Original---
From: "Ye ***@***.***>
Date: Wed, Mar 17, 2021 19:50 PM
To: ***@***.***>;
Cc: ***@***.***>;
Subject: [taichi-dev/taichi] [refactor] Create a library taichi_isolated_core that is free from pybind11 (#2218)
Related issue = #2196
This PR makes various clean up to make taichi_isolated_core include every source file except for those under taichi/python/. With this in place, it's possible to unit test a major part of Taichi. @BillXu2000 should also be able to link with taichi_isolated_core to use both the IR and the runtime.
[Click here for the format server]
You can view, comment on, or merge this pull request online at:
#2218
Commit Summary
[refactor] Create taichi_isolated_core that is free from pybind11
[skip ci] enforce code format
File Changes
M cmake/TaichiCore.cmake (65)
M cmake/TaichiTests.cmake (2)
A taichi/backends/cuda/detect_cuda.cpp (17)
A taichi/backends/cuda/detect_cuda.h (5)
M taichi/backends/metal/kernel_manager.cpp (2)
M taichi/backends/opengl/opengl_api.cpp (2)
M taichi/ir/ir.cpp (6)
M taichi/ir/ir.h (8)
M taichi/ir/statements.h (6)
M taichi/lang_util.cpp (2)
M taichi/program/program.cpp (7)
A taichi/program/py_print_buffer.cpp (7)
R taichi/program/py_print_buffer.h (8)
M taichi/python/export_lang.cpp (3)
M taichi/python/export_misc.cpp (15)
M taichi/python/interfaces_registry.cpp (2)
R taichi/python/memory_usage_monitor.cpp (10)
R taichi/python/memory_usage_monitor.h (4)
A taichi/python/py_exception_translator.cpp (31)
M taichi/system/hacked_signal_handler.cpp (12)
A taichi/system/interface_registry.cpp (13)
Patch Links:
https://github.com/taichi-dev/taichi/pull/2218.patch
https://github.com/taichi-dev/taichi/pull/2218.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
yes |
k-ye
requested review from
taichi-gardener
and removed request for
taichi-gardener
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2196
This PR makes various clean up to make
taichi_isolated_coreinclude every source file except for those undertaichi/python/. With this in place, it's possible to unit test a major part of Taichi. @BillXu2000 should also be able to link withtaichi_isolated_coreto use both the IR and the runtime.Note that this requires cmake 3.12 because we need to link with the
OBJECTlibrary (see https://stackoverflow.com/a/51436025/12003165). Since "cmake 3.12" was released on July 2018, this should be OK for all the developers/[Click here for the format server]