[refactor] Cleanup python imports #2226
Conversation
| # object within it, is that ti_core is stateful. While in practice ti_core is | ||
| # loaded during the import procedure, it's probably still good to delay the | ||
| # access to it. | ||
| from taichi.core import util as cutil |
There was a problem hiding this comment.
We should probably do this for all the other aliases of ti_core as well?
|
|
||
|
|
||
| @unit('task') | ||
| def _unit(unit_name): |
There was a problem hiding this comment.
unit was a wrapper over the legacy interface/impl-managing system used in legacy Taichi. I think there are still usages of unit. task is an example: https://taichi.readthedocs.io/en/stable/contributor_guide.html?highlight=libdevice#upgrading-cuda
The interface/unit system is intended to improve the modularity of the legacy Taichi library. I think we do not need them anymore. Given it seems overdesigned at this point, we may need to at least simplify it...
There was a problem hiding this comment.
Ah I see.
task is an example:
Right. I searched for @unit and tasks is the only user, so I moved unit here (instead of staying at core)..
|
|
||
|
|
||
| @unit('task') | ||
| def _unit(unit_name): |
There was a problem hiding this comment.
unit was a wrapper over the legacy interface/impl-managing system used in legacy Taichi. I think there are still usages of unit. task is an example: https://taichi.readthedocs.io/en/stable/contributor_guide.html?highlight=libdevice#upgrading-cuda
The interface/unit system is intended to improve the modularity of the legacy Taichi library. I think we do not need them anymore. Given it seems overdesigned at this point, we may need to at least simplify it...
| # object within it, is that ti_core is stateful. While in practice ti_core is | ||
| # loaded during the import procedure, it's probably still good to delay the | ||
| # access to it. | ||
| from taichi.core import util as cutil |
Related issue = #2223
[Click here for the format server]