[test] Add tests for value_diff_ptr_index pass #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ye
commented
Apr 3, 2021
xumingkuan
approved these changes
Apr 3, 2021
Comment on lines
26
to
30
| auto *const1 = builder.get_float32(1.0f); | ||
| auto *const2 = builder.get_float32(1.0f); | ||
|
|
||
| const auto diff = value_diff_ptr_index(const1, const2); | ||
| EXPECT_FALSE(diff.is_diff_certain); |
There was a problem hiding this comment.
We don't check floating-point numbers since the pass is for pointer indices. Maybe add some comment?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2193
A preliminary step before adding some tests for alias analysis.
[Click here for the format server]