Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] Move uniquely_accessed_bit_structs from compile_to_offloads to AnalysisManager #2264

Merged
merged 3 commits into from
Apr 14, 2021
Merged

[ir] Move uniquely_accessed_bit_structs from compile_to_offloads to AnalysisManager #2264

merged 3 commits into from
Apr 14, 2021

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan xumingkuan commented Apr 13, 2021 •
edited
Loading

Related issue = #2193 #2252

It seems that std::unique_ptr cannot be static_cast in get_pass_result() so I cast the raw pointer instead.

[Click here for the format server]

k-ye
k-ye approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k-ye k-ye merged commit ef0d81c into taichi-dev:master Apr 14, 2021
@xumingkuan xumingkuan deleted the pass-mngr3 branch April 20, 2021 05:11
@k-ye k-ye mentioned this pull request Apr 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xumingkuan @k-ye