-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM] Add random seed support #2297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y present in the argument to initialize call
…ichi into random_seed_2251
ljcc0930
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #2251
This is the last of 3 PRs regarding #2251, which allows for specification of random seed when initializing Taichi runtime. With different random seeds, two Taichi runtime contexts on the same machine (presumably) and backend will produce different random number sequences, and vice versa. The corresponding
test_random_seed_per_program
test fails before this PR and passes after.Due to the parallel nature of Taichi runtime, the random seed is multiplied by 2^20 to obtain the initial random state for the RNG, assuming that number of threads is well below 2^20 so that no two threads share the same random state.
As the title suggests, specification of random seed only works for CPU and CUDA backends. For OpenGL and Metal backends the random seed always varies from run to run.
[Click here for the format server]