[bug] Protect against path with space #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
approved these changes
May 4, 2021
yuanming-hu
changed the title
e.g. "C:\Users\Cheng Cao\source\repos\taichi" will be interpreted as "C:\Users\Cheng" and "Cao\source\repos\taichi", and causing the runtime bitcode compilation to fail (llvm_context.cpp line 152 `void compile_runtime_bitcode(Arch arch)`)
bobcao3
force-pushed
the
bugfix-compile-bitcode-filepath
branch
from
a4953eb to
a9ea2f8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect against path with space.
e.g. "C:\Users\Cheng Cao\source\repos\taichi" will be interpreted as "C:\Users\Cheng" and "Cao\source\repos\taichi", and causing the runtime bitcode compilation to fail (llvm_context.cpp line 152
void compile_runtime_bitcode(Arch arch))Related issue = #2317