Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Use native resolution (client scaling) on WIN32 #2320

Merged
merged 1 commit into from
May 6, 2021

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented May 3, 2021

Related issue = #2316

@bobcao3
Copy link
Collaborator Author

bobcao3 commented May 3, 2021

Two of the commits are included accidentally. The actual change is the one-liner in commit 23efb42. This PR probably needs some sanitation.

@k-ye
Copy link
Member

k-ye commented May 5, 2021

Thank you for improving the GUI! As you've pointed out, this PR has a large overlap with #2315, could you separate the two pls :-) ?

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@k-ye k-ye merged commit 865c22a into taichi-dev:master May 6, 2021
@BillXu2000 BillXu2000 mentioned this pull request May 13, 2021
@k-ye
Copy link
Member

k-ye commented Jun 21, 2021

Some user reported that Taichi no longer worked on their Win7 since https://github.com/taichi-dev/taichi/releases/tag/v0.7.19.

ImportError: DLL load failed while importing taichi_core

I took a look and this PR seems to be the most suspicious one. Could you help take a look whether this change has introduced some new DLL dependency? Thanks!

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 21, 2021

I just checked and it seems that this DPI awareness mode only exists post windows 8.1. This might need some detection scheme, but I'm not sure whether this can be a runtime variant or it must be compile time.

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 21, 2021

@k-ye
Copy link
Member

k-ye commented Jun 22, 2021

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 22, 2021

#2450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants