-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Use native resolution (client scaling) on WIN32 #2320
Conversation
Two of the commits are included accidentally. The actual change is the one-liner in commit 23efb42. This PR probably needs some sanitation. |
Thank you for improving the GUI! As you've pointed out, this PR has a large overlap with #2315, could you separate the two pls :-) ? |
…perfect windows without system scaling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Some user reported that Taichi no longer worked on their Win7 since https://github.com/taichi-dev/taichi/releases/tag/v0.7.19.
I took a look and this PR seems to be the most suspicious one. Could you help take a look whether this change has introduced some new DLL dependency? Thanks! |
I just checked and it seems that this DPI awareness mode only exists post windows 8.1. This might need some detection scheme, but I'm not sure whether this can be a runtime variant or it must be compile time. |
Thanks. Can we use https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setprocessdpiaware?redirectedfrom=MSDN for Win7 compatibility? |
Related issue = #2316