Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt] Better encapsulate BLS bounds #2341

Merged
merged 4 commits into from
May 14, 2021
Merged

[opt] Better encapsulate BLS bounds #2341

merged 4 commits into from
May 14, 2021

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented May 13, 2021

@k-ye k-ye force-pushed the bls branch 2 times, most recently from 19f6343 to 2c975e3 Compare May 14, 2021 05:25
@k-ye k-ye requested review from xumingkuan and KLozes May 14, 2021 08:36
xumingkuan
xumingkuan approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general!

taichi/ir/scratch_pad.h
Comment on lines -227 to -228
TI_P(it.second.bounds[0]);
TI_P(it.second.bounds[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If this function is merely used for debugging, why not printing bounds as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

taichi/transforms/make_block_local.cpp Outdated Show resolved Hide resolved
taichi/transforms/make_block_local.cpp Outdated Show resolved Hide resolved
k-ye and others added 3 commits May 14, 2021 22:39
@k-ye @xumingkuan
Update taichi/transforms/make_block_local.cpp
b699109 
Co-authored-by: xumingkuan <xumingkuan0721@126.com>
@k-ye @xumingkuan
Update taichi/transforms/make_block_local.cpp
9af38bd 
Co-authored-by: xumingkuan <xumingkuan0721@126.com>
@k-ye
apply review
6399cc3
@k-ye k-ye merged commit 0a25bf5 into taichi-dev:master May 14, 2021
@k-ye k-ye deleted the bls branch May 14, 2021 15:37
@xumingkuan xumingkuan mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xumingkuan xumingkuan xumingkuan approved these changes

@KLozes KLozes Awaiting requested review from KLozes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-ye @xumingkuan