Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] Make Aot module dumps buffer size #2431

Merged
merged 11 commits into from
Jun 18, 2021
Merged

Conversation

Scoutydren
Copy link
Contributor

Related issue = #

Make Aot module dump buffer size, so as to launch kernels in Apple environments.

@Scoutydren
Copy link
Contributor Author

/format

1 similar comment
@k-ye
Copy link
Member

k-ye commented Jun 16, 2021

/format

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few minor suggestions. Also you should be able to "/format" now :-)


#include "taichi/backends/metal/kernel_util.h"

TLANG_NAMESPACE_BEGIN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace taichi {
namespace lang {

taichi/backends/metal/taichi_file_util.h Outdated Show resolved Hide resolved
taichi/backends/metal/taichi_file_util.h Outdated Show resolved Hide resolved
taichi/backends/metal/taichi_file_util.h Outdated Show resolved Hide resolved
taichi/backends/metal/kernel_manager.h Outdated Show resolved Hide resolved
taichi/backends/metal/taichi_file_util.h Outdated Show resolved Hide resolved
taichi/backends/metal/kernel_manager.cpp Outdated Show resolved Hide resolved
taichi/backends/metal/taichi_file_util.h Outdated Show resolved Hide resolved
@Scoutydren
Copy link
Contributor Author

/format

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + nits!

taichi/backends/metal/aot_module_builder_impl.h Outdated Show resolved Hide resolved
taichi/backends/metal/aot_module_builder_impl.h Outdated Show resolved Hide resolved
@k-ye k-ye merged commit b131412 into taichi-dev:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants