-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metal] Make Aot module dumps buffer size #2431
Conversation
/format |
1 similar comment
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a few minor suggestions. Also you should be able to "/format" now :-)
|
||
#include "taichi/backends/metal/kernel_util.h" | ||
|
||
TLANG_NAMESPACE_BEGIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace taichi {
namespace lang {
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + nits!
Related issue = #
Make Aot module dump buffer size, so as to launch kernels in Apple environments.