Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fixed windows build & test #2434

Merged
merged 4 commits into from
Jun 16, 2021
Merged

[CI] Fixed windows build & test #2434

merged 4 commits into from
Jun 16, 2021

Conversation

Leonz5288
Copy link
Contributor

Related issue = #2428

@Leonz5288 Leonz5288 requested a review from k-ye June 16, 2021 07:44
k-ye
k-ye approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM + nits

k-ye
k-ye reviewed Jun 16, 2021
View reviewed changes
taichi/runtime/llvm/runtime.cpp
// The latest MSVC uses llvm-11 as requirements. However, we use llvm-10
// for now and building will fail due to clang version mismatch. Therefore,
// we workaround this problem by define such flag to skip the version check.
#define _ALLOW_COMPILER_AND_STL_VERSION_MISMATCH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update the comments

@Leonz5288
Copy link
Contributor Author

/format

@k-ye k-ye merged commit 4c86e6e into taichi-dev:master Jun 16, 2021
@k-ye k-ye mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leonz5288 @k-ye @taichi-gardener