Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Misc improvements over AST helper functions #4398

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

re-xyr
Copy link
Contributor

@re-xyr re-xyr commented Feb 27, 2022

Related issue = fixes #4199

  • Renamed several PascalCase helpers to snake_case
  • Removed the include of expression_ops.h from expression.h - any file that needs it should import it individually
  • Added taichi::lang::value<T>(const T &x) as a version of taichi::lang::Expr::Expr that allows specifying types explicitly
  • Other misc improvements

@netlify
Copy link

netlify bot commented Feb 27, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: cbd461e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/622c682c44fdaa00093fefb6

😎 Browse the preview: https://deploy-preview-4398--docsite-preview.netlify.app

taichi/python/export_lang.cpp Outdated Show resolved Hide resolved
taichi/ir/frontend.h Outdated Show resolved Hide resolved
taichi/ir/expr.h Show resolved Hide resolved
taichi/ir/expression_ops.h Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

@strongoier strongoier merged commit a6acc91 into taichi-dev:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Principled C++ side Expr construction helpers
2 participants