Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Support simple matrix slicing #4488

Merged
merged 11 commits into from
Mar 15, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Mar 9, 2022

Related issue = #4257
Making the matrix slice stronger based on the dynamic index. Support one row or one column slice.

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: af4c3b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/623036e47ca6b40008beae0f

😎 Browse the preview: https://deploy-preview-4488--docsite-preview.netlify.app

@mzmzm mzmzm changed the title fix test [Lang] Support simple matrix slicing Mar 9, 2022
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
@mzmzm
Copy link
Contributor Author

mzmzm commented Mar 14, 2022

/format

tests/python/test_simple_matrix_slice.py Show resolved Hide resolved
python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit e56ac6a into taichi-dev:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants