[build] Option to use LLD #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 14c6e60 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/622eda5dfe51c5000843f353 😎 Browse the preview: https://deploy-preview-4513--docsite-preview.netlify.app |
ailzhang
approved these changes
Mar 11, 2022
| @@ -56,6 +56,12 @@ if(CCACHE_PROGRAM) | |||
| set(CMAKE_CXX_COMPILER_LAUNCHER "${CCACHE_PROGRAM}") | |||
| endif() | |||
|
|
|||
| if (USE_LLD) | |||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fuse-ld=lld") | |||
There was a problem hiding this comment.
Can you make USE_LLD an option so that we can set it through TAICHI_CMAKE_ARGS?
There was a problem hiding this comment.
I think you can, I did that on my end.
There was a problem hiding this comment.
Yea I did try that and it worked :P . I meant we should add it in this PR to make it more usable. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Seems to have worked on my end)