[build] Default symbol visibility to hidden for all targets #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taichi can be used by external applications that has conflicting dependencies such as ImGui or Vulkan. In order to avoid any conflicts or nasty bugs, enforce the visibility to 'hidden' by default so only the public API is exported. This moves the config to the global property instead of the per target property
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 816bf7c 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62312e83e251b700098ca471 |
k-ye
approved these changes
Mar 16, 2022
qiao-bo
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taichi can be used by external applications that has conflicting
dependencies such as ImGui or Vulkan. In order to avoid any conflicts or
nasty bugs, enforce the visibility to 'hidden' by default so only the
public API is exported.
This moves the config to the global property instead of the per target
property