Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Add TI_CI env to CI/CD #4551

Merged
merged 2 commits into from
Mar 17, 2022
Merged

[misc] Add TI_CI env to CI/CD #4551

merged 2 commits into from
Mar 17, 2022

Conversation

Leonz5288
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: 1e0a409

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62329b3aad6d8c00089b3a3d

😎 Browse the preview: https://deploy-preview-4551--docsite-preview.netlify.app

ailzhang
ailzhang reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm why do we need this?

@Leonz5288
Copy link
Contributor Author

We want to also record CI in user data. This is to tag CI records.

frostming
frostming reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@frostming frostming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should better be put once in the top level, the same as on and jobs

env:
  TI_CI: 1

@strongoier strongoier merged commit 37a9d2c into taichi-dev:master Mar 17, 2022
@Leonz5288 Leonz5288 deleted the tici branch March 17, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming left review comments

@ailzhang ailzhang ailzhang left review comments

@strongoier strongoier strongoier approved these changes

@qiao-bo qiao-bo Awaiting requested review from qiao-bo

@rexwangcc rexwangcc Awaiting requested review from rexwangcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leonz5288 @strongoier @ailzhang @frostming