[aot] Support return in vulkan aot #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulkan aot return didn't work since it was trying to serialize `Datatype` which was a raw pointer. This PR fixes the issue by changing it to a `PrimitiveTypeID` which is a `int`. Note it's possible that we limit general `Kernel` args and rets to be primitive types only but leaving that to a followup PR to avoid making this PR too complicated.
|
✅ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: aff5aca 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/62386a549c45ef0009e05b73 😎 Browse the preview: https://deploy-preview-4593--docsite-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan aot return didn't work since it was trying to serialize
Datatypewhich was a raw pointer. This PR fixes the issue by changingit to a PrimitiveTypeID which is a
int. Note it's possible that welimit Kernel args and rets to be primitive types only but leaving that
to a followup PR to avoid making this PR too complicated.
Related issue = #