Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Refactored field.md #4618

Merged
merged 8 commits into from
Mar 28, 2022
Merged

[Doc] Refactored field.md #4618

merged 8 commits into from
Mar 28, 2022

Conversation

writinwaters
Copy link
Contributor

@writinwaters writinwaters commented Mar 24, 2022

Please also pay attention to the code snippet. I updated the code (a little bit) and the annotations, and I'm not 100% sure of my explanations of the code.

Related issue = #

@writinwaters
Copy link
Contributor Author

/format

@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 338e53a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6241c1ef52fb40000843c1c2
😎 Deploy Preview https://deploy-preview-4618--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@neozhaoliang neozhaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement on earlier versions, LGTM!
Also, The last section, shall we also explain more on the two terms individually and universally?

docs/lang/articles/basic/field.md Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
docs/lang/articles/basic/field.md Outdated Show resolved Hide resolved
@neozhaoliang
Copy link
Contributor

/format

@writinwaters
Copy link
Contributor Author

/format

@writinwaters
Copy link
Contributor Author

All requests have been implemented. We can put this PR to bed.

@k-ye k-ye merged commit 9b887cb into taichi-dev:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants