[Autodiff] Implement ti.ad.no_grad to skip autograd #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shwnyao
changed the title
shwnyao
changed the title
shwnyao
changed the title
k-ye
pushed a commit
to k-ye/taichi
that referenced
this pull request
May 5, 2022
* [Autodiff]: implement ti.ad.no_gradto skip autograd * [Autodiff]: update ti.ad.no_grad tests and remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4747
The implementation should be expressive enough, which is to replace the auto grad function with an empty function.
This is my first PR to an open source project! While it's certainly exciting to me, please excuse me if any requirements are missing.
Another issue when I'm writing tests is that while the contribution guideline requires using
@ti.testto decorate the test functions, all tests for the Autodiff module is prepended with the@test_utils.testdecorator. I decided to follow the convention and if that is not recommended, please let me know too.