-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ci] Simplify the workflow syntax by using containers #4776
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed? |
Which Ubuntu 18.04 are you referring to? CI runs-on ubuntu-latest which is 20.04 i think. Only our docker image is built with Ubuntu 18.04 |
Yes, this PR changes those running inside a docker container, which is ubuntu 18.04. |
The reason was that using Ubuntu 20.04 will introduce some dependencies that do not work on Ubuntu 18.04,, such as Glibc 2.29 and such. Therefore, we currently build, test, and release using 18.04. ;/ |
Understood, it makes sense. |
@qiao-bo So I updated the dockerfile to install newer git version, do you know how can I build these images? Thanks |
It can be built locally with nvidia-docker using |
Here is an old PR #3226 when I was playing with Dockerfiles. Some instructions may be outdated. Not sure if it helps. |
Thanks, I have stripped out the Dockerfile changes into #4785. |
Closing since these changes does not apply anymore. |
WIP PR
It is the first step toward unifying the workflow jobs on multiple os(at least I hope so).
Remaining Work