Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ci] Simplify the workflow syntax by using containers #4776

Closed
wants to merge 8 commits into from

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Apr 13, 2022

WIP PR

It is the first step toward unifying the workflow jobs on multiple os(at least I hope so).

Remaining Work

  • Workspace root permission issue
  • Use setup-conda action to replace the conda in container
  • Potential GUI display issue

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 0debc51
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/625cb2951e1747000987186f
😎 Deploy Preview https://deploy-preview-4776--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@frostming
Copy link
Collaborator Author

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed?

@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 13, 2022

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed?

Which Ubuntu 18.04 are you referring to? CI runs-on ubuntu-latest which is 20.04 i think. Only our docker image is built with Ubuntu 18.04

@frostming
Copy link
Collaborator Author

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed?

Which Ubuntu 18.04 are you referring to? CI runs-on ubuntu-latest which is 20.04 i think. Only our docker image is built with Ubuntu 18.04

Yes, this PR changes those running inside a docker container, which is ubuntu 18.04.

@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 13, 2022

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed?

Which Ubuntu 18.04 are you referring to? CI runs-on ubuntu-latest which is 20.04 i think. Only our docker image is built with Ubuntu 18.04

Yes, this PR changes those running inside a docker container, which is ubuntu 18.04.

The reason was that using Ubuntu 20.04 will introduce some dependencies that do not work on Ubuntu 18.04,, such as Glibc 2.29 and such. Therefore, we currently build, test, and release using 18.04. ;/

@frostming
Copy link
Collaborator Author

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

The git version on ubuntu 18.0.4 seems too old to make github actions work correctly. @qiao-bo @rexwangcc is it possible to upgrade to the ubuntu 20.04 image? Is there any other concern that I missed?

Which Ubuntu 18.04 are you referring to? CI runs-on ubuntu-latest which is 20.04 i think. Only our docker image is built with Ubuntu 18.04

Yes, this PR changes those running inside a docker container, which is ubuntu 18.04.

The reason was that using Ubuntu 20.04 will introduce some dependencies that do not work on Ubuntu 18.04,, such as Glibc 2.29 and such. Therefore, we currently build, test, and release using 18.04. ;/

Understood, it makes sense.

@frostming
Copy link
Collaborator Author

@qiao-bo So I updated the dockerfile to install newer git version, do you know how can I build these images? Thanks

@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 13, 2022

@qiao-bo So I updated the dockerfile to install newer git version, do you know how can I build these images? Thanks

It can be built locally with nvidia-docker using nvidia-docker build -t name:tag . BTW, can you open a separate PR for updating the Dockerfile with git?

ci/Dockerfile.ubuntu.18.04 Outdated Show resolved Hide resolved
@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 13, 2022

Here is an old PR #3226 when I was playing with Dockerfiles. Some instructions may be outdated. Not sure if it helps.

@frostming
Copy link
Collaborator Author

@qiao-bo So I updated the dockerfile to install newer git version, do you know how can I build these images? Thanks

It can be built locally with nvidia-docker using nvidia-docker build -t name:tag . BTW, can you open a separate PR for updating the Dockerfile with git?

Thanks, I have stripped out the Dockerfile changes into #4785.

@frostming frostming changed the title [Ci] Simply the workflow syntax to use container [Ci] Simplify the workflow syntax to use container Apr 15, 2022
@frostming frostming changed the title [Ci] Simplify the workflow syntax to use container [Ci] Simplify the workflow syntax by using containers Apr 16, 2022
@feisuzhu
Copy link
Contributor

Closing since these changes does not apply anymore.

@feisuzhu feisuzhu closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants