[lang] Store relations with 16-bit type #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
g1n0st
force-pushed
the
16-bits-rel-storage
branch
from
e7a1e63 to
6e81e7f
Compare
for more information, see https://pre-commit.ci
k-ye
pushed a commit
to k-ye/taichi
that referenced
this pull request
May 5, 2022
* offset/value from int32 -> uint16, add auxiliary data 'patch_offset' * update mesh test * remove i16 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3608
Now the relation metadata of
ti.Meshstores inuint16type instead ofint32to save the global memory footprint and bandwidth at almost 2x for the relations.For the dynamic relations like
VV, now we store an auxiliary datapatch_offsetto represent the start address ofdatafor each patch, andoffsetonly represents the local prefix within a patch. So theoffsetdata can be packed intouint16type.