Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix bug that building with gcc9.4 will fail #4823

Merged

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Apr 20, 2022

Related issue = #

@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 0a80df9
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/625f7774b347de00091cb4ab

Copy link
Contributor

@g1n0st g1n0st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@strongoier strongoier merged commit cc9661f into taichi-dev:master Apr 20, 2022
@k-ye
Copy link
Member

k-ye commented Apr 20, 2022

What's your original purpose for using TI_FORCE_INLINE?

@PGZXB
Copy link
Contributor Author

PGZXB commented Apr 20, 2022

What's your original purpose for using TI_FORCE_INLINE?

I used TI_FORCE_INLINE at

get_offline_cache_key_of_compile_config(CompileConfig *config) {

which is only a internal util function and a long function, so I force-inlined it. And this don't cause failed building.

Then I used it at

static void get_offline_cache_key_of_snode_impl(

without thinking, for similar purpose (but in fact, the function cannot be force inlined because of recursive calling).

I'm so sorry, my bad

@k-ye
Copy link
Member

k-ye commented Apr 21, 2022

OK I see... Let's trust the compilers for now, which should be very good at figuring out what to inline these days. We can manually inline when the profiling results indicate this is a bottleneck :-)

k-ye pushed a commit to k-ye/taichi that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants