[mesh] Remove link hints from ti.Mesh #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
k-ye
reviewed
Apr 20, 2022
|
Updated. There is now a separate AST processing pass to detect mesh relation visiting, though only some simple cases of detections are handled. For complicated situations, users need to manually tell compiler which relations are needed. |
for more information, see https://pre-commit.ci
k-ye
approved these changes
Apr 21, 2022
|
HI @BillXu2000, could you fix the CI build failure problem? |
for more information, see https://pre-commit.ci
k-ye
pushed a commit
to k-ye/taichi
that referenced
this pull request
May 5, 2022
* scratch * auto vv * relations from metadata and patcher * remove comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add python pass to detect relation visits * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * todo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * try fix test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * adjust comments Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3608
All the necessary relation information will be detected in ast transformer.
Relations that has not been stored in fields will be fetched from patcher.
I am not sure whether it is appropriate to store mesh information in compile context and update mesh information in kernel_impl.py.