Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Warning Suppression PR #3: Eliminate warnings from third-party headers #4920

Merged
merged 6 commits into from
May 7, 2022
Merged

[build] Warning Suppression PR #3: Eliminate warnings from third-party headers #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0091a0a
[build] Warning Suppression PR #1: Turned on -Wno-ignored-attributes …
jim19930609 May 6, 2022
d73d236
Merge branch 'master' of github.com:taichi-dev/taichi into warnings_s…
jim19930609 May 6, 2022
c6ba16b
[build] Warning Suppression PR #2: Eliminate warnings from third-part…
jim19930609 May 6, 2022
27cfff2
Fixed an warning with enum comparison
jim19930609 May 7, 2022
ce86b61
Merge branch 'master' of github.com:taichi-dev/taichi into warnings_s…
jim19930609 May 7, 2022
2d36391
Merge branch 'master' of github.com:taichi-dev/taichi into warnings_s…
jim19930609 May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmake/TaichiCore.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,9 @@ if (TI_WITH_VULKAN)

target_include_directories(${CORE_LIBRARY_NAME} PRIVATE external/SPIRV-Headers/include)
target_include_directories(${CORE_LIBRARY_NAME} PRIVATE external/SPIRV-Reflect)
target_include_directories(${CORE_LIBRARY_NAME} PRIVATE external/VulkanMemoryAllocator/include)

# By specifying SYSTEM, we suppressed the warnings from third-party headers.
target_include_directories(${CORE_LIBRARY_NAME} SYSTEM PRIVATE external/VulkanMemoryAllocator/include)

if (LINUX)
# shaderc requires pthread
Expand Down
2 changes: 1 addition & 1 deletion taichi/backends/vulkan/vulkan_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ void VulkanPipeline::create_descriptor_set_layout(const Params &params) {

for (auto var : variables) {
// We want to remove auxiliary outputs such as frag depth
if (var->built_in == -1) {
if (static_cast<int>(var->built_in) == -1) {
render_target_count++;
}
}
Expand Down