[vulkan] Set kApiVersion to VK_API_VERSION_1_3 #4958
Conversation
This change fixes issue taichi-dev#4900. On certain AMD GPUs (such as RX 5500), the Vullkan version needs to be 1.3 in order for Volk to correctly populate the "vkGetDeviceBufferMemoryRequirements" function pointer. If the version is 1.2, the pointer will be NULL and cause an assertion failure. Tested by running the voxel challenge program and see the program working as expected on a Windows PC.
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! But what's the implication of this for Vk1.2 users? Note that the majority of our CI bots are still running 1.2. Ideally we should not hardcode this one, and configure it via env var or |
|
Yes this is a valid concern. I guess the right fix would be in the vulkan_device.cpp plus the version flag, and I'm not very familiar with that part yet. I think this PR has served its purpose in asking the question about the version and can be closed and be superseded by a better solution. |
|
It's good to know that this simple change fixes the problem on AMD GPUs, thanks! |
|
I also encountered similar problem on 6900XT, which crashes on vmaCreateAllocator. This patch can also fix my problem. Thanks! |
This change fixes issue #4900. On certain AMD GPUs (such as RX 5500), the Vullkan version needs to be 1.3 in order for Volk to correctly populate the "vkGetDeviceBufferMemoryRequirements" function pointer. If the version is 1.2, the pointer will be NULL and cause an assertion failure.
Tested by running the voxel challenge program and see the program working as expected on a Windows PC.
According to the manual page, this function appears to be from Vulkan 1.3, and as such I guess kApiVersion would need to be set to 1.3 as well. I'm not sure if this means legacy devices would be excluded?
Related issue = #4900 #4951