Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aot] [llvm] LLVM AOT Field part-4: Added AOT tests for Fields - CUDA backend #5124

Merged
merged 11 commits into from
Jun 15, 2022
Merged

[aot] [llvm] LLVM AOT Field part-4: Added AOT tests for Fields - CUDA backend #5124

merged 11 commits into from
Jun 15, 2022

Conversation

jim19930609
Copy link
Contributor

Related issue = #4800

@netlify
Copy link

netlify bot commented Jun 10, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 44c2c1d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a93c5101fe3b0009544b18
😎 Deploy Preview https://deploy-preview-5124--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jim19930609 jim19930609 changed the title [aot] [llvm] LLVM AOT Field #4: Added AOT tests for Fields running CUDA backend [aot] [llvm] LLVM AOT Field #4: Added AOT tests for Fields - CUDA backend Jun 10, 2022
@jim19930609 jim19930609 requested review from ailzhang and k-ye June 14, 2022 04:58
k-ye
k-ye approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

nit on the title: Let's avoid using #\d+ in the title, cause it could link to irrelevant issue/PRs... An alternative would be \d+/n

tests/cpp/backends/llvm/field_aot_cuda.py Outdated Show resolved Hide resolved
tests/cpp/backends/llvm/field_aot_test.cpp Outdated Show resolved Hide resolved
tests/cpp/backends/llvm/field_aot_test.cpp Outdated Show resolved Hide resolved
@jim19930609
Copy link
Contributor Author

Awesome!

nit on the title: Let's avoid using #\d+ in the title, cause it could link to irrelevant issue/PRs... An alternative would be \d+/n

Thanks, didn't realize this myself :) Will stick to the alternative solution and avoid using "#" in the tile.

@jim19930609 jim19930609 changed the title [aot] [llvm] LLVM AOT Field #4: Added AOT tests for Fields - CUDA backend [aot] [llvm] LLVM AOT Field part-4: Added AOT tests for Fields - CUDA backend Jun 15, 2022
@jim19930609 jim19930609 requested a review from k-ye June 15, 2022 02:35
@jim19930609 jim19930609 merged commit d0d70ae into taichi-dev:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang Awaiting requested review from ailzhang

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jim19930609 @k-ye