Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autodiff] [refactor] Refactor autodiff tape api and TapeImpl #5154

Merged
merged 8 commits into from
Jun 14, 2022

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Jun 13, 2022

Related issue = #
Simplify the implementation of Tape.
Move the implementation of Tape to taichi.ad.
Make ti.Tape deprecated and use ti.ad.Tape instead.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 90d4225
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a7fe82235e70000970a6ad
😎 Deploy Preview https://deploy-preview-5154--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@erizmr erizmr requested a review from ailzhang June 14, 2022 02:54
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

tests/python/test_api.py Show resolved Hide resolved
python/taichi/ad.py Outdated Show resolved Hide resolved
@ailzhang ailzhang merged commit 09aa8f5 into taichi-dev:master Jun 14, 2022
@erizmr erizmr deleted the refactor_tape branch June 14, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants