Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Properlly fix UTF-8 title string by converting to UTF16 #5155

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 13, 2022

Related issue = #5135

@bobcao3 bobcao3 requested a review from PENGUINLIONG June 13, 2022 18:01
@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 413bdb8
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a77ba41866f9000820b1de
😎 Deploy Preview https://deploy-preview-5155--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bobcao3 bobcao3 changed the title [win32] Properlly fix UTF-8 title string by converting to UTF16 [ui] Properlly fix UTF-8 title string by converting to UTF16 Jun 13, 2022
@PENGUINLIONG
Copy link
Member

thanks! lgtm

@bobcao3 bobcao3 merged commit 53b2a2e into taichi-dev:master Jun 14, 2022
@bobcao3 bobcao3 deleted the bobcao3/fix-win32-window branch June 15, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants