[llvm] [refactor] LLVMProgramImpl code clean up: part-3 #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
jim19930609
requested review from
ailzhang,
k-ye and
strongoier
and removed request for
ailzhang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4800, #5114
Let's avoid accessing LlvmProgramImpl with "dynamic_cast + macro" in high-level object such as
program.cpporkernel.cpp, which strongly burdens the macro management.For the place where ProgramImpl gets dispatched to each backend-specific XXXProgramImpl, it will stay unchanged for now. Will file another issue to discuss how we can replace that with "template + linking"