Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Slim cpu build image #5198

Merged
merged 1 commit into from
Jun 18, 2022
Merged

[ci] Slim cpu build image #5198

merged 1 commit into from
Jun 18, 2022

Conversation

feisuzhu
Copy link
Contributor

Related issue = #4824

@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit d66ec8c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62ac3cb0942507000bc5ca72
😎 Deploy Preview https://deploy-preview-5198--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feisuzhu feisuzhu force-pushed the feat/slim-cpu-build-image branch from 75cd587 to d66ec8c Compare June 17, 2022 08:34
@feisuzhu feisuzhu marked this pull request as ready for review June 17, 2022 08:37
@feisuzhu
Copy link
Contributor Author

12.1GB -> 6GB

@feisuzhu feisuzhu requested a review from qiao-bo June 17, 2022 08:37
qiao-bo
qiao-bo reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I wonder did the size reduction mainly from the switch to pytorch-cpu? Another question is are there any potential risks by using the conda-forge channel?

@feisuzhu
Copy link
Contributor Author

feisuzhu commented Jun 17, 2022 •
edited
Loading

Thanks a lot! I wonder did the size reduction mainly from the switch to pytorch-cpu?

Yes, that's the main reason.

Another question is are there any potential risks by using the conda-forge channel?

I didn't do thorough analysis but observed all test cases are passed.

@qiao-bo qiao-bo merged commit 34a7db4 into taichi-dev:master Jun 18, 2022
@feisuzhu feisuzhu deleted the feat/slim-cpu-build-image branch June 23, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiao-bo qiao-bo qiao-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feisuzhu @qiao-bo