Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl #5207

Merged
merged 12 commits into from
Jun 23, 2022

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Jun 20, 2022

Related issue = #4800, #5114

There are two major customer-level classes, namely Kernel and FieldsBuilder. Both Kernel and FieldsBuilder rely on Program/ProgramImpl to access compile-time and runtime interfaces.

However, AOT runtime requires a standalone runtime interface decoupled from the compile-time interfaces. To satisfy AOT needs, this PR splits LlvmRuntimeExecutor out from LlvmProgramImpl:

  1. LlvmRuntimeExecutor: contains only runtime objects and interfaces
  2. LlvmProgramImpl: contains compile-time interfaces and some wrapper functions to access runtime interfaces (for use in JIT)

*Note: Compile - runtime split for TaichiLLVMContext is reserved for successive PRs.

image

@netlify
Copy link

netlify bot commented Jun 20, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 0041a45
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b3e6dc047c820008e1ed64

@jim19930609 jim19930609 changed the title [llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl part-1 [llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl Jun 22, 2022
taichi/llvm/llvm_runtime.h Outdated Show resolved Hide resolved
taichi/llvm/llvm_runtime.h Outdated Show resolved Hide resolved
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jim19930609 jim19930609 requested a review from k-ye June 23, 2022 04:07
@jim19930609 jim19930609 merged commit 5cd3339 into taichi-dev:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants