-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl #5207
Merged
jim19930609
merged 12 commits into
taichi-dev:master
from
jim19930609:runtime_executor_0
Jun 23, 2022
Merged
[llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl #5207
jim19930609
merged 12 commits into
taichi-dev:master
from
jim19930609:runtime_executor_0
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
jim19930609
changed the title
[llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl part-1
[llvm] [aot] Split LlvmRuntimeExecutor from LlvmProgramImpl
Jun 22, 2022
k-ye
reviewed
Jun 23, 2022
k-ye
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4800, #5114
There are two major customer-level classes, namely Kernel and FieldsBuilder. Both Kernel and FieldsBuilder rely on Program/ProgramImpl to access compile-time and runtime interfaces.
However, AOT runtime requires a standalone runtime interface decoupled from the compile-time interfaces. To satisfy AOT needs, this PR splits LlvmRuntimeExecutor out from LlvmProgramImpl:
*Note: Compile - runtime split for TaichiLLVMContext is reserved for successive PRs.