Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable pylint on examples #5222

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

feisuzhu
Copy link
Contributor

Related issue = #5141

Sorry for the massive change T_T
But most changes are variable renaming and top level code containing (to a function).

I'd recommend to use https://github.com/Wilfred/difftastic as the diff tool to see ONLY THE SEMANTIC changes.

@netlify
Copy link

netlify bot commented Jun 21, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit cbc265c
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b41aa918d07b0008760b2b
😎 Deploy Preview https://deploy-preview-5222--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feisuzhu feisuzhu requested a review from ailzhang June 21, 2022 11:27
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks!!

@k-ye
Copy link
Member

k-ye commented Jun 21, 2022

I'd recommend to use https://github.com/Wilfred/difftastic as the diff tool to see ONLY THE SEMANTIC changes.

Would be great if this can be made a extension online!

@feisuzhu feisuzhu merged commit 37b1dbd into taichi-dev:master Jun 23, 2022
@feisuzhu feisuzhu deleted the fix/pylint-on-examples branch June 23, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants