Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lang] 1d/3d texture support #5233

Merged
merged 7 commits into from
Jun 24, 2022
Merged

[lang] 1d/3d texture support #5233

merged 7 commits into from
Jun 24, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 22, 2022

Related issue = #5109

@bobcao3 bobcao3 requested a review from ailzhang June 22, 2022 19:53
@netlify
Copy link

netlify bot commented Jun 22, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit bd3fc27
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b3e7bfc0c62900083fdc63
😎 Deploy Preview https://deploy-preview-5233--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bobcao3 bobcao3 requested a review from turbo0628 June 22, 2022 19:53
@bobcao3 bobcao3 changed the title [lang] 3d texture support [lang] 1d/3d texture support Jun 22, 2022
@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 23, 2022

3D texture tested in https://github.com/bobcao3/voxel-challenge

@bobcao3 bobcao3 requested a review from k-ye June 23, 2022 05:39
k-ye
k-ye approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can we test this feature? One way would probably to generate a 2D image on the fly, sample a few known points on it, and compare with the result.

@k-ye k-ye merged commit 072cf01 into taichi-dev:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

@turbo0628 turbo0628 Awaiting requested review from turbo0628

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobcao3 @k-ye