Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Fix OpBranch for reversed RangeForStmt #5241

Merged
merged 2 commits into from
Jun 23, 2022
Merged

[vulkan] Fix OpBranch for reversed RangeForStmt #5241

merged 2 commits into from
Jun 23, 2022

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Jun 23, 2022 •
edited
Loading

Related issue = #5239 #5221

@erizmr erizmr requested a review from bobcao3 June 23, 2022 15:10
@netlify
Copy link

netlify bot commented Jun 23, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 351d9d4
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b4ee919a7cc00009e0db38

bobcao3
bobcao3 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobcao3
Copy link
Collaborator

bobcao3 commented Jun 23, 2022 •
edited
Loading

Can we put the repro (from #5239) into the test suite? Thanks!

@erizmr
Copy link
Contributor Author

erizmr commented Jun 23, 2022

Can we put the repro (from #5239) into the test suite? Thanks!

Sure.

@erizmr erizmr merged commit 4040922 into taichi-dev:master Jun 23, 2022
@erizmr erizmr deleted the spriv_reverse_for branch June 23, 2022 23:40
@bobcao3 bobcao3 mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcao3 bobcao3 bobcao3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erizmr @bobcao3