Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Added safety checks to prevent hard crashes on failure #5249

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

PENGUINLIONG
Copy link
Member

This PR added safety checks to Taichi C-APIs, so that a call with apparently invalid arguments won't trigger a hard crash. Human readable warning are logged for debugability.

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 4184e19
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b5390328fb4100087e4eee
😎 Deploy Preview https://deploy-preview-5249--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PENGUINLIONG PENGUINLIONG changed the title Added safety checks to prevent hard crashes on failure [AOT] Added safety checks to prevent hard crashes on failure Jun 24, 2022
@PENGUINLIONG PENGUINLIONG requested a review from k-ye June 24, 2022 05:05
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PENGUINLIONG PENGUINLIONG merged commit 8314d01 into taichi-dev:master Jun 24, 2022
@PENGUINLIONG PENGUINLIONG deleted the capi-check1 branch June 24, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants