Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autodiff] [test] Add atomic test for forward autodiff #5286

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Jun 29, 2022

Related issue = #5055

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 3642f9b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62bc2de275e66e0008a8fad8
😎 Deploy Preview https://deploy-preview-5286--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@erizmr erizmr changed the title [autodiff][test] Add atomic test for forward autodiff [autodiff] [test] Add atomic test for forward autodiff Jun 29, 2022
@erizmr erizmr requested a review from ailzhang June 29, 2022 06:29
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I think atomic in this kernel is demoted and didn't reach the end. Can we the kernel to avoid demotion? Thanks!

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit d1b61eb into taichi-dev:master Jun 30, 2022
@erizmr erizmr deleted the fwd_test_atomic branch June 30, 2022 01:49
@erizmr erizmr mentioned this pull request Jul 4, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants