Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Accept numpy integers in ndrange (#5245) #5323

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

feisuzhu
Copy link
Contributor

@feisuzhu feisuzhu commented Jul 4, 2022

Related issue = #5245

@feisuzhu feisuzhu requested review from ailzhang and AD1024 July 4, 2022 10:46
@netlify
Copy link

netlify bot commented Jul 4, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 6e20127
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62c2c644419d2000085b640e
😎 Deploy Preview https://deploy-preview-5323--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AD1024
Copy link
Contributor

AD1024 commented Jul 4, 2022

LGTM! Thanks for the fix🙏🏻

@feisuzhu feisuzhu merged commit c4e8d36 into taichi-dev:master Jul 5, 2022
@feisuzhu feisuzhu deleted the fix/ndrange branch July 5, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants