Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Add get_view_matrix() and get_projection_matrix() APIs for camera #5345

Merged
merged 18 commits into from
Jul 7, 2022
Merged

[gui] Add get_view_matrix() and get_projection_matrix() APIs for camera #5345

merged 18 commits into from
Jul 7, 2022

Conversation

Morcki
Copy link
Member

@Morcki Morcki commented Jul 6, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 6, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit b22640b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62c53baec0dbb700090095fb
😎 Deploy Preview https://deploy-preview-5345--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Morcki Morcki changed the title [gui] [Camera] Add 2 new functions to get camara view/proj matrix [gui] Add 2 new functions to get camara view/proj matrix Jul 6, 2022
@Morcki Morcki marked this pull request as draft July 6, 2022 06:18
@Morcki Morcki marked this pull request as ready for review July 6, 2022 06:18
@Morcki Morcki marked this pull request as draft July 6, 2022 06:22
@Morcki Morcki marked this pull request as ready for review July 6, 2022 06:23
@YuCrazing YuCrazing changed the title [gui] Add 2 new functions to get camara view/proj matrix [GUI] Add get_view_matrix() and get_projection_matrix() for camera Jul 6, 2022
@YuCrazing YuCrazing changed the title [GUI] Add get_view_matrix() and get_projection_matrix() for camera [GGUI] Add get_view_matrix() and get_projection_matrix() for camera Jul 6, 2022
@YuCrazing YuCrazing changed the title [GGUI] Add get_view_matrix() and get_projection_matrix() for camera [GGUI] Add get_view_matrix() and get_projection_matrix() APIs for camera Jul 6, 2022
YuCrazing
YuCrazing reviewed Jul 6, 2022
View reviewed changes
taichi/python/export_ggui.cpp Outdated Show resolved Hide resolved
taichi/python/export_ggui.cpp Outdated Show resolved Hide resolved
taichi/python/export_ggui.cpp Outdated Show resolved Hide resolved
taichi/python/export_ggui.cpp Outdated Show resolved Hide resolved
taichi/python/export_ggui.cpp Outdated Show resolved Hide resolved
@YuCrazing YuCrazing requested review from AmesingFlank and k-ye July 6, 2022 07:08
@YuCrazing YuCrazing changed the title [GGUI] Add get_view_matrix() and get_projection_matrix() APIs for camera [GGUI] Add get_view_matrix and get_projection_matrix APIs for camera Jul 6, 2022
@YuCrazing YuCrazing changed the title [GGUI] Add get_view_matrix and get_projection_matrix APIs for camera [GGUI] Add get_view_matrix() and get_projection_matrix() APIs for camera Jul 6, 2022
Morcki and others added 5 commits July 6, 2022 15:11
@Morcki @YuCrazing
Update taichi/python/export_ggui.cpp
b28bb81 
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
@Morcki @YuCrazing
Update taichi/python/export_ggui.cpp
c2eee88 
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
@Morcki @YuCrazing
Update taichi/python/export_ggui.cpp
74230fb 
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
@Morcki @YuCrazing
Update taichi/python/export_ggui.cpp
a2965ec 
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
@Morcki @YuCrazing
Update taichi/python/export_ggui.cpp
eea04db 
Co-authored-by: YuZhang <YuCrazing@users.noreply.github.com>
@YuCrazing YuCrazing changed the title [GGUI] Add get_view_matrix() and get_projection_matrix() APIs for camera [gui] Add get_view_matrix() and get_projection_matrix() APIs for camera Jul 6, 2022
YuCrazing
YuCrazing approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@YuCrazing YuCrazing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Great To Me!

@YuCrazing YuCrazing requested a review from strongoier July 6, 2022 08:59
@YuCrazing YuCrazing merged commit c374dfe into taichi-dev:master Jul 7, 2022
@YuCrazing YuCrazing mentioned this pull request Jul 14, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuCrazing YuCrazing YuCrazing approved these changes

@AmesingFlank AmesingFlank Awaiting requested review from AmesingFlank

@k-ye k-ye Awaiting requested review from k-ye

@strongoier strongoier Awaiting requested review from strongoier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morcki @CLAassistant @YuCrazing