Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [refactor] (Decomp of #5251 6/n) Let ModuleToFunctionConverter support multiple modules #5372

Merged
merged 4 commits into from
Jul 9, 2022

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented Jul 8, 2022

Related issue = #5252
Decomposition of #5251

Made ModuleToFunctionConverter an abstract class.

Currently only CPU backend supports multiple modules, the implementation of CUDA backend only supports a single module.

@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 9d42a1e
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62c7d74d7c853e00080201bc
😎 Deploy Preview https://deploy-preview-5372--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lin-hitonami lin-hitonami requested a review from jim19930609 July 8, 2022 06:31
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/codegen/cuda/codegen_cuda.h Outdated Show resolved Hide resolved
@lin-hitonami lin-hitonami merged commit 8292973 into taichi-dev:master Jul 9, 2022
@lin-hitonami lin-hitonami deleted the module+converter branch July 9, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants