Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type] [refactor] Decouple quant from SNode 5/n: Rewrite load_quant_float() without SNode #5422

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[type] [refactor] Decouple quant from SNode 5/n: Rewrite load_quant_float() without SNode #5422

merged 2 commits into from
Jul 15, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #4857

@netlify
Copy link

netlify bot commented Jul 14, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 98b9de3
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62cf87112a8c97000988a4d2

@strongoier strongoier requested review from ailzhang and k-ye July 14, 2022 06:09
ailzhang
ailzhang approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@ailzhang ailzhang merged commit d3184b4 into taichi-dev:master Jul 15, 2022
@strongoier strongoier deleted the bitpack-1 branch July 15, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strongoier @ailzhang