Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type] [refactor] Decouple quant from SNode 9/n: Remove exponent handling from SNode #5510

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #4857

The BitStructType is now completely constructed via BitStructTypeBuilder.

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 4b3afea
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62de3504f3e785000ae19d8f
😎 Deploy Preview https://deploy-preview-5510--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@strongoier strongoier requested review from ailzhang and k-ye July 25, 2022 07:16
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 2dda83e into taichi-dev:master Jul 26, 2022
@strongoier strongoier deleted the remove-snode-redundant branch July 26, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants