Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AOT] Added texture interfaces to C-API #5520

Merged
merged 8 commits into from
Aug 12, 2022
Merged

[AOT] Added texture interfaces to C-API #5520

merged 8 commits into from
Aug 12, 2022

Conversation

PENGUINLIONG
Copy link
Member

This PR introduced texture interfaces to C-API.

(WIP) Don't merge!

@netlify
Copy link

netlify bot commented Jul 26, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit fe6dc93
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62f4c59f09f4c900096b984a
😎 Deploy Preview https://deploy-preview-5520--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PENGUINLIONG PENGUINLIONG mentioned this pull request Jul 27, 2022
Closed
@PENGUINLIONG PENGUINLIONG force-pushed the capi-texture1 branch 4 times, most recently from 3dbe382 to c1f1d7e Compare August 5, 2022 06:53
@PENGUINLIONG
Copy link
Member Author

/rebase

bobcao3
bobcao3 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@bobcao3 bobcao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@jim19930609
Copy link
Contributor

Super! Btw it would be nice if we can write some comments on each newly-added public interface, to explain its functionality, each argument and return? Structs such as TiTextureAllocateInfo, TiVulkanTextureInteropInfo might also need some documentaries.

Some unit tests for each public interface is also welcomed! (maybe in a separate PR)

@PENGUINLIONG
Copy link
Member Author

Super! Btw it would be nice if we can write some comments on each newly-added public interface, to explain its functionality, each argument and return? Structs such as TiTextureAllocateInfo, TiVulkanTextureInteropInfo might also need some documentaries.

Some unit tests for each public interface is also welcomed! (maybe in a separate PR)

I'm working on a detailed documentation on C-API interfaces. It might take a while to be published tho. 😉

@PENGUINLIONG PENGUINLIONG merged commit fde8352 into taichi-dev:master Aug 12, 2022
@PENGUINLIONG PENGUINLIONG deleted the capi-texture1 branch August 12, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcao3 bobcao3 bobcao3 approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

@jim19930609 jim19930609 Awaiting requested review from jim19930609

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PENGUINLIONG @jim19930609 @bobcao3