[Lang] [type] Refine SNode with quant 8/n: Replace bit_struct with ti.BitpackedFields #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
strongoier
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
/rebase |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
taichi-gardener
force-pushed
the
add-bitpacked-fields
branch
from
c2e9062 to
7ced615
Compare
…nto add-bitpacked-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #4857
This PR finishes the API change proposed in #4857 (comment).
bit_structis now removed from the Python side. There is still some code aroundbit_structSNode left in C++ side, which is mainly to ease internal implementation and will no longer block future development, so we can just leave them there.